Skip to content

add support for Boolean dtypes for dpctl.tensor.ceil, dpctl.tensor.floor, and dpctl.tensor.trunc#2033

Merged
vtavana merged 3 commits intomasterfrom
support-boolean-bounding-funcs
Mar 31, 2025
Merged

add support for Boolean dtypes for dpctl.tensor.ceil, dpctl.tensor.floor, and dpctl.tensor.trunc#2033
vtavana merged 3 commits intomasterfrom
support-boolean-bounding-funcs

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Mar 27, 2025 •
edited
Loading

In this PR, support for Boolean dtype is added to dpctl.tensor.ceil, dpctl.tensor.floor, and dpctl.tensor.trunc.
resolves #2030

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@vtavana vtavana self-assigned this Mar 27, 2025
@github-actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Mar 27, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_73 ran successfully.
Passed: 894
Failed: 2
Skipped: 154

@coveralls
Copy link
Collaborator

coveralls commented Mar 27, 2025 •
edited
Loading

Coverage Status

coverage: 86.752%. remained the same
when pulling 9a79047 on support-boolean-bounding-funcs
into 63f5129 on master.

@github-actions
Copy link

github-actions bot commented Mar 27, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_74 ran successfully.
Passed: 894
Failed: 2
Skipped: 154

@vtavana vtavana marked this pull request as ready for review March 27, 2025 21:38
@ndgrigorian
Copy link
Collaborator

ndgrigorian commented Mar 28, 2025

I've looked it over and the changes look good, but I'd like to fix the Windows CI before merging if possible

antonwolfy
antonwolfy reviewed Mar 28, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Mar 31, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_75 ran successfully.
Passed: 895
Failed: 1
Skipped: 154

@ndgrigorian
Copy link
Collaborator

ndgrigorian commented Mar 31, 2025

@vtavana
Windows CI fix is merged so please merge master into this branch or rebase to pick it up

@vtavana vtavana force-pushed the support-boolean-bounding-funcs branch from dc3eea7 to 9a79047 Compare March 31, 2025 16:54
@github-actions
Copy link

github-actions bot commented Mar 31, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_78 ran successfully.
Passed: 894
Failed: 2
Skipped: 154

ndgrigorian
ndgrigorian approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you @vtavana

@vtavana vtavana merged commit 579d2f8 into master Mar 31, 2025
68 checks passed
@ndgrigorian ndgrigorian deleted the support-boolean-bounding-funcs branch April 15, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dpctl.tensor returns int8 arrays from ceil, trunc and floor function for bool input array

4 participants

@vtavana @coveralls @ndgrigorian @antonwolfy